Beau Beauchamp Sat May 07 08:02:52 -0400 2011

Subject: BUG REPORT: PHP-only Files are Using Closing PHP Tags

First of all, I LOVE PHP ActiveRecord! :D

However, if you want your library to be included within Zend Framework-based application, all PHP-only files should not be using closing PHP tags. "For files that contain only PHP code, the closing tag ("?>") is never permitted. It is not required by PHP, and omitting it´ prevents the accidental injection of trailing white space into the response."

See: http://framework.zend.com/manual/en/coding-standard.php-file-formatting.html

Cheers!

-Beau


Yoan B Sat May 07 08:44:06 -0400 2011

What problems cause those trailing ?>? Other frameworks have other best practices, i.e. http://rad-dev.org/lithium/wiki/standards/coding

And should should follow the link issues(http://github.com/kla/php-activerecord/issues) within the footer for reporting bugs.

Beau Beauchamp Sat May 07 11:48:21 -0400 2011

Thanks for the issue link, Yoan. Trailing closing tags can cause accidental injection of trailing white space into the response. On some frameworks or scripts, this can cause fatal errors at line 0 and no way to tell what the problem really is. The folks at Zend who make PHP recommend against using closing tags so that should give more weight regarding who is advocating the proper best practices. ;)

-Beau

Yoan B Sat May 07 13:54:13 -0400 2011

As PHP-ActiveRecord is a library, even a tested one, none of those problems should occur or not being spotted. If it ain't broke don't fix. Nothing's broken here.

Beau Beauchamp Sun May 08 07:41:41 -0400 2011

There is more to coding than, "it ain't broke". There are also "acceptable coding standards" that should be maintained if the library is every going to be used within more than just the hobby community. I think PHP ActiveRecord stands a very good chance of being pushed into Zend Framework as an alternative to Doctrine's bloated codebase. I'm currently working with PHP AR in Zend and so far it looks pretty good.

You should not be offended or get defensive when enterprise-class developers start offering suggestions for taking the library to the next level. Otherwise we'll just blow off the development effort as immature and move on. Learn to take critiques in the gentle manner in which they are offered and learn from others whose experience will really help the codebase mature. That's the problem with too many developers, they think they know it all and they refuse to accept suggestions for improvement from more advanced people in the industry who adhere to standards-based coding.

Yoan B Sun May 08 14:00:34 -0400 2011

All I'm saying is that it is really nite-picking here.

PHP ActiveRecord require more good stuff than useless convention fights. It's an open source world and I'm not one of the PHP AR maintainers. Fork it, fix it, and ask for a merge. I believe in do-ocracy (http://www.communitywiki.org/en/DoOcracy): do it or shut up!

What do you know about “chances to be pushed into ZF”?

Maybe the Zend Framework 2 (PHP 5.3!) as an alternative to Doctrine 2 (which won't ship with ZF2 btw http://framework.zend.com/wiki/display/ZFDEV2/Doctrine2)

Sorry for being rude, I just don't see the value of such BUG REPORT post/issue if the only problem spotted is a taste problem (that's really about it).

(1-5/5)